Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Sphinx 7.2 #69

Closed
kai687 opened this issue Aug 17, 2023 · 6 comments · Fixed by #70
Closed

Error with Sphinx 7.2 #69

kai687 opened this issue Aug 17, 2023 · 6 comments · Fixed by #70

Comments

@kai687
Copy link

kai687 commented Aug 17, 2023

app.outdir is now a Path, not a string,
so line 213 breaks.

@kai687
Copy link
Author

kai687 commented Aug 17, 2023

sphinx-doc/sphinx#11608

@larsoner
Copy link
Contributor

Opened #70, hopefully it works 🤞

@jdillard
Copy link
Owner

Thanks! I'll have to test it out to make sure it doesn't break for older versions (it doesn't seem to be) and update tox as well now that 7 is out.

@larsoner
Copy link
Contributor

I'll have to test it out to make sure it doesn't break for older versions (it doesn't seem to be) and update tox as well now that 7 is out.

Want me to add that parametrization to continuous_integration.yml? Then you don't have to manually test this...

@larsoner
Copy link
Contributor

... couldn't resist the temptation. Added to #70 but I can revert if needed

@jdillard
Copy link
Owner

Thanks for pointing that out @kai687 and thanks for the great work in the PR @larsoner!

2.5.1 is out now with the fix: https://github.com/jdillard/sphinx-sitemap/releases/tag/v2.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants