-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputnumber): value 大于 max 图标应处于禁用态 #3107
Conversation
Walkthrough该提交更新了 InputNumber 组件中减号和加号按钮的禁用条件。现当 shadowValue 小于或等于 min 时,减号按钮禁用;当 shadowValue 大于或等于 max 时,加号按钮禁用。此次修改仅调整了内部逻辑判断,并未变更导出或公共实体的声明。 Changes
Sequence Diagram(s)sequenceDiagram
participant User as 用户
participant Comp as InputNumber 组件
User->>Comp: 点击减号按钮
alt shadowValue <= min
Comp->>Comp: 禁用减号按钮
else
Comp->>Comp: 执行减操作
end
User->>Comp: 点击加号按钮
alt shadowValue >= max
Comp->>Comp: 禁用加号按钮
else
Comp->>Comp: 执行加操作
end
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3107 +/- ##
==========================================
Coverage 86.49% 86.49%
==========================================
Files 280 280
Lines 18492 18494 +2
Branches 2774 2775 +1
==========================================
+ Hits 15994 15996 +2
Misses 2493 2493
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit