feat(#277): remove redundant code

Author: volodya-lombrozo

src/main/java/com/jcabi/xml/DomParser.java

@@ -31,6 +31,7 @@
 
 import com.jcabi.log.Logger;
 import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
 import java.io.File;
 import java.io.IOException;
 import java.io.InputStream;
@@ -100,10 +101,6 @@ final class DomParser {
     }
 
 
-    DomParser(final DocumentBuilderFactory fct, final InputStream stream) {
-        this(fct, new StreamSource(stream));
-    }
-
     DomParser(final DocumentBuilderFactory fct, final File file) {
         this(fct, new FileSource(file));
     }
@@ -155,22 +152,33 @@ public Document document() {
         return doc;
     }
 
+    /**
+     * Source of XML.
+     * @since 0.32
+     */
     private interface DocSource {
 
         Document apply(DocumentBuilder builder) throws IOException, SAXException;
 
         long length();
     }
 
+    /**
+     * File source of XML from a file.
+     * @since 0.32
+     */
     private static class FileSource implements DocSource {
 
+        /**
+         * The file.
+         */
         private final File file;
 
-        private FileSource(final Path path) {
-            this(path.toFile());
-        }
-
-        private FileSource(final File file) {
+        /**
+         * Public ctor.
+         * @param file The file.
+         */
+        FileSource(final File file) {
             this.file = file;
         }
 
@@ -185,38 +193,30 @@ public long length() {
         }
     }
 
-
-    private static class StreamSource implements DocSource {
-
-        private final InputStream stream;
-
-        public StreamSource(final InputStream stream) {
-            this.stream = stream;
-        }
-
-        @Override
-        public Document apply(final DocumentBuilder builder) throws IOException, SAXException {
-            final Document res = builder.parse(this.stream);
-            this.stream.close();
-            return res;
-        }
-
-        @Override
-        public long length() {
-            return 0;
-        }
-    }
-
-
+    /**
+     * Bytes source of XML.
+     * @since 0.32
+     */
     private static class BytesSource implements DocSource {
 
+        /**
+         * Bytes of the XML.
+         */
         private final byte[] xml;
 
-        private BytesSource(final String xml) {
+        /**
+         * Public ctor.
+         * @param xml Bytes of the XML.
+         */
+        BytesSource(final String xml) {
             this(xml.getBytes(StandardCharsets.UTF_8));
         }
 
-        private BytesSource(final byte[] xml) {
+        /**
+         * Public ctor.
+         * @param xml Bytes of the XML.
+         */
+        BytesSource(final byte[] xml) {
             this.xml = xml;
         }
 
@@ -227,7 +227,7 @@ public Document apply(final DocumentBuilder builder) throws IOException, SAXExce
 
         @Override
         public long length() {
-            return xml.length;
+            return this.xml.length;
         }
     }
 }

src/main/java/com/jcabi/xml/XMLDocument.java

@@ -184,7 +184,7 @@ public XMLDocument(final File file) throws FileNotFoundException {
     }
 
     /**
-     * Public ctor, from input stream.
+     * Public ctor, from XML in a file.
      *
      * <p>The object is created with a default implementation of
      * {@link NamespaceContext}, which already defines a
@@ -193,19 +193,15 @@ public XMLDocument(final File file) throws FileNotFoundException {
      * <p>An {@link IllegalArgumentException} is thrown if the parameter
      * passed is not in XML format.
      *
-     * <p>The provided input stream will be closed automatically after
-     * getting data from it.
-     *
-     * @param stream The input stream, which will be closed automatically
-     * @throws IOException In case of I/O problem
+     * @param file XML file
+     * @throws FileNotFoundException In case of I/O problems
      */
-    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
-    public XMLDocument(final InputStream stream) throws IOException {
-        this(new DomParser(XMLDocument.configuredDFactory(), stream).document());
+    public XMLDocument(final Path file) throws FileNotFoundException {
+        this(new DomParser(XMLDocument.configuredDFactory(), file.toFile()).document());
     }
 
     /**
-     * Public ctor, from XML in a file.
+     * Public ctor, from input stream.
      *
      * <p>The object is created with a default implementation of
      * {@link NamespaceContext}, which already defines a
@@ -214,11 +210,16 @@ public XMLDocument(final InputStream stream) throws IOException {
      * <p>An {@link IllegalArgumentException} is thrown if the parameter
      * passed is not in XML format.
      *
-     * @param file XML file
-     * @throws FileNotFoundException In case of I/O problems
+     * <p>The provided input stream will be closed automatically after
+     * getting data from it.
+     *
+     * @param stream The input stream, which will be closed automatically
+     * @throws IOException In case of I/O problem
      */
-    public XMLDocument(final Path file) throws FileNotFoundException {
-        this(new DomParser(XMLDocument.configuredDFactory(), file.toFile()).document());
+    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
+    public XMLDocument(final InputStream stream) throws IOException {
+        this(new TextResource(stream).toString());
+        stream.close();
     }
 
     /**