Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link to fontawesome/brands icons #337

Open
radek-chramosil opened this issue Apr 8, 2024 · 1 comment · May be fixed by #338
Open

Broken link to fontawesome/brands icons #337

radek-chramosil opened this issue Apr 8, 2024 · 1 comment · May be fixed by #338
Labels
documentation Improvements or additions to documentation

Comments

@radek-chramosil
Copy link

Hi there,

I thought I would let you know that you often pointing to fontawesome brands icons in the documentation. However, when I click on the link, it takes me to the repo, however the icons are not there.]

This is the broken link.

https://github.com/squidfunk/mkdocs-material/tree/master/material/.icons

I am not sure where to look up the right set of icons. mkdocs-material moved the icons.

Best,
Radek

@2bndy5
Copy link
Collaborator

2bndy5 commented Apr 8, 2024

Yeah, the mkdocs-material theme has undergone a refactor since that doc was written. They now exist in https://github.com/squidfunk/mkdocs-material/tree/master/material/templates/.icons

IMO, that link (even when it worked) is not very helpful because github only displays a portion of the files in a large folder. I'd prefer using the links listed in the inline-icons doc, but that doesn't help describe the folder structure used for the vendors of the icons. Some examples:

@2bndy5 2bndy5 added the documentation Improvements or additions to documentation label Apr 8, 2024
2bndy5 added a commit that referenced this issue Apr 11, 2024
TODO: uncomment `search` and `previous` entries when search.py ext is battle-hardened

also resolves #337 by updating the link to upstream's source folder
2bndy5 added a commit that referenced this issue Apr 11, 2024
also resolves #337 by updating the link to upstream's source folder
@2bndy5 2bndy5 linked a pull request Apr 12, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants