-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix max table width calculation #289
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 94.38% 94.48% +0.10%
==========================================
Files 5 5
Lines 2404 2431 +27
==========================================
+ Hits 2269 2297 +28
+ Misses 135 134 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
there is always an additional column, if ruler is visible or not
Hi @hugovk is something missing here? Are you waiting for something to be added? |
Hi! Thank you very much for the PR! I'm just waiting to find time to review it :) I'll definitely try to get to it this month. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! This is mainly style/readability suggestions.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Thank you very much! |
Try to fix max_table_width computation
fixes: #288