Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in pytest fixture name #1271

Merged
merged 1 commit into from
May 21, 2023
Merged

Fix typo in pytest fixture name #1271

merged 1 commit into from
May 21, 2023

Conversation

tonial
Copy link
Contributor

@tonial tonial commented May 15, 2023

Description of the Change

The fixture was named loggend_in_client instead of logged_in_client

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #1271 (61c733a) into master (29da530) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1271   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files          31       31           
  Lines        1996     1996           
=======================================
  Hits         1942     1942           
  Misses         54       54           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@dopry dopry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dopry dopry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dopry dopry merged commit 016c6c3 into jazzband:master May 21, 2023
28 checks passed
@tonial tonial deleted the tonial/typo branch May 22, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants