Fix RP-initiated Logout with expired Django session #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1270 +/- ##
==========================================
+ Coverage 97.19% 97.29% +0.10%
==========================================
Files 31 31
Lines 1994 1996 +2
==========================================
+ Hits 1938 1942 +4
+ Misses 56 54 -2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tonial
force-pushed
the
tonial/rp_logout_expired_session
branch
from
4f22a3a
to
d65cb9a
Compare
Co-authored-by: François Freitag <mail@franek.fr>
Co-authored-by: François Freitag <mail@franek.fr>
Co-authored-by: François Freitag <mail@franek.fr>
for more information, see https://pre-commit.ci
francoisfreitag
approved these changes
May 15, 2023
|
@tonial good catch. I'm not super jazzed about the complex return type from _validate_logout_request. I feel like that could be broken up into a few discrete methods on the RPInitiatedLogoutView and more of the validation workflow could be lifted up into form_valid. Once I complete some local testing, I'll merge so we fix the breakage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1269
Description of the Change
Fix RP initiated logout when there's no django session available.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS