Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actualize docs about AuthenticationMiddleware #1267

Merged
merged 2 commits into from
May 8, 2023

Conversation

Akay7
Copy link
Contributor

@Akay7 Akay7 commented May 8, 2023

Fixes #684

Description of the Change

There's changes in SessionAuthenticationMiddleware. I'm just slightly modified docs.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Looks like #684 missed this documentation change.

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #1267 (1546c68) into master (9dd1033) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1267   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files          31       31           
  Lines        1821     1821           
=======================================
  Hits         1766     1766           
  Misses         55       55           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@n2ygk n2ygk merged commit 25f6de5 into jazzband:master May 8, 2023
28 checks passed
@Akay7 Akay7 deleted the actualizeDocs branch May 9, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SessionAuthenticationMiddleware removed from django v2.0 onwards.
2 participants