Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix- CODE_CHALLENGE instead of CODE_VERIFIER in docs #1208

Merged
merged 3 commits into from
Oct 4, 2022
Merged

Hotfix- CODE_CHALLENGE instead of CODE_VERIFIER in docs #1208

merged 3 commits into from
Oct 4, 2022

Conversation

matiseni51
Copy link
Contributor

@matiseni51 matiseni51 commented Sep 30, 2022

Fixes #1207

Description of the Change

code_challenge_method=S256 in authorize call added in getting_started documentation

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk
Copy link
Member

n2ygk commented Oct 4, 2022

@matiseni51 please fill out the pull request template (not sure how that got missed) and add it to the description.

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #1208 (d95d218) into master (9383e08) will decrease coverage by 0.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1208      +/-   ##
==========================================
- Coverage   96.85%   96.04%   -0.82%     
==========================================
  Files          31       26       -5     
  Lines        1813     1314     -499     
==========================================
- Hits         1756     1262     -494     
+ Misses         57       52       -5     
Impacted Files Coverage Δ
oauth2_provider/admin.py
oauth2_provider/models.py
oauth2_provider/settings.py
oauth2_provider/urls.py
oauth2_provider/__init__.py

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@matiseni51
Copy link
Contributor Author

@n2ygk sorry, my bad.

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@n2ygk n2ygk merged commit da459a1 into jazzband:master Oct 4, 2022
@n2ygk n2ygk added this to the 2.2.0 milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs - code_verifier in authorization_code
3 participants