Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates "getting started" documentation for required PKCE #1159

Merged
merged 4 commits into from
May 17, 2022

Conversation

alemangui
Copy link
Contributor

@alemangui alemangui commented May 16, 2022

Adds PKCE token instructions to be in sync with 2.0 version.

Fixes #1153

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

alemangui and others added 3 commits May 16, 2022 11:39
AUTHORS Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #1159 (cbf004e) into master (78c91d9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1159   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          31       31           
  Lines        1794     1794           
=======================================
  Hits         1738     1738           
  Misses         56       56           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c91d9...cbf004e. Read the comment docs.

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo

docs/getting_started.rst Outdated Show resolved Hide resolved
Co-authored-by: Alan Crosswell <alan@crosswell.us>
@n2ygk n2ygk merged commit 4f04a57 into jazzband:master May 17, 2022
@n2ygk n2ygk changed the title Updates "getting started" documentation Updates "getting started" documentation for required PKCE May 17, 2022
@alemangui alemangui deleted the patch-1 branch May 18, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting started section is not up to date with 2.0 release
2 participants