Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance createapplication command to display autogenerated secret #1152

Merged
merged 4 commits into from
May 7, 2022

Conversation

n2ygk
Copy link
Member

@n2ygk n2ygk commented May 7, 2022

Fixes #1151

Description of the Change

Enhance the createapplication management command to display the cleartext secret when it's been autogenerated since it gets stored hashed. Also display the client name or ID. And improves the --help documentation.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk requested a review from a team May 7, 2022 14:41
@n2ygk n2ygk added this to the 2.0.1 milestone May 7, 2022
@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #1152 (4cd0c61) into master (025cd1b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1152   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          31       31           
  Lines        1790     1794    +4     
=======================================
+ Hits         1734     1738    +4     
  Misses         56       56           
Impacted Files Coverage Δ
..._provider/management/commands/createapplication.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025cd1b...4cd0c61. Read the comment docs.

Copy link
Contributor

@rcmurphy rcmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo in the changelog; otherwise looks good!

CHANGELOG.md Outdated Show resolved Hide resolved
@n2ygk n2ygk requested a review from rcmurphy May 7, 2022 15:57
@n2ygk n2ygk merged commit 6f3ebcf into jazzband:master May 7, 2022
@n2ygk n2ygk deleted the issue_1151/client_secret branch May 7, 2022 18:35
@n2ygk n2ygk modified the milestones: 2.0.1, 2.1.0 Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add some client-secret required tips when python manage.py createapplication in version >= 2.0.0
2 participants