Fix request listeners registered in contextHandlerConfig #1983
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently migrated an application from spark to javalin 5, and we use
the sentry servlet integration to enrich our sentry error reporting, and
noticed it wasn't actually getting called in the javalin app.
The default ContextHandler's
doHandle
method does the necessaryinvocations of
ServletRequestListener
s that have been registered, andI think just calling
super
to get that handling inwsAndHttpHandler
isthe correct behavior, but maybe there was some reason that it intentionally
did not call
super.doHandle
that I missed. It appears this will be anon-issue in Javalin 6 since this handling was refactored in a way that
removed the method override, but I think this is worth fixing in Javalin 5.