Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request listeners registered in contextHandlerConfig #1983

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

maths22
Copy link
Contributor

@maths22 maths22 commented Aug 19, 2023

I recently migrated an application from spark to javalin 5, and we use
the sentry servlet integration to enrich our sentry error reporting, and
noticed it wasn't actually getting called in the javalin app.

The default ContextHandler's doHandle method does the necessary
invocations of ServletRequestListeners that have been registered, and
I think just calling super to get that handling in wsAndHttpHandler is
the correct behavior, but maybe there was some reason that it intentionally
did not call super.doHandle that I missed. It appears this will be a
non-issue in Javalin 6 since this handling was refactored in a way that
removed the method override, but I think this is worth fixing in Javalin 5.

@tipsy tipsy merged commit 0d070e5 into javalin:javalin-5x Aug 19, 2023
9 checks passed
@maths22 maths22 deleted the fix-request-listeners branch August 19, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants