Integrate reported quality issues #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unload Reported by: @sebbASF Closes: java-native-access#1561
|
@dbwiddis could you please have a look at this? There are differences regarding the suggested approach by @sebbASF, but the core matches. Where I took a different route:
|
|
Good point; not sure how I missed that. I no longer think that handle needs to be volatile. |
dbwiddis
approved these changes
Dec 5, 2023
| @@ -245,7 +245,7 @@ public static Function getFunction(Pointer p, int callFlags, String encoding) { | |||
| this.library = library; | |||
| this.functionName = functionName; | |||
| this.callFlags = callFlags; | |||
| this.options = library.options; | |||
| this.options = library.getOptions(); | |||
There was a problem hiding this comment.
This map is still mutable; if someone modified the library map (e.g. getOptions.clear() that would echo here.
Now that we are on JDK8 I'd suggest making this version of it an unmodifiable copy. (I'd suggest making the getter return unmodifiable but that's probably a breaking change.)
Suggested change
| this.options = library.getOptions(); | |
| this.options = Map.copyOf(library.getOptions()); |
|
Thanks for the review. I'll integrate as if for now, I think the discussion about potentially user facing changes needs some more time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1560
Closes: #1561