Fix support for absolute paths in srcDir and specDir #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of path.join(projectBaseDir, srcDir), we should use path.resolve(projectBaseDir, srcDir). Where join() will always join paths, resolve() will resolve relative paths relative to the previous argument, but leave absolute paths alone. Closes jasmine#15
|
I checked that the new test case fails without the fix (converting path.join to path.resolve every time projectBaseDir is involved), but passes with the fix. Please take a look! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of path.join(projectBaseDir, srcDir), we should use path.resolve(projectBaseDir, srcDir). Where join() will always join paths, resolve() will resolve relative paths relative to the previous argument, but leave absolute paths alone.
Closes #15