Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump oauth from 0.9.x to 0.10.x #165

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

Quentin-Danjou
Copy link
Contributor

This is solving issues of passport-google-oauth2 as stated in issue #163

This is solving multiple issues of `passport-google-oauth2` as stated in issue jaredhanson#163
@ahmet
Copy link

ahmet commented Aug 26, 2022

need this

@TwistedLogic
Copy link

Can you please merge this and release a new version? passport-spotify has issues.

@Quentin-Danjou
Copy link
Contributor Author

@jaredhanson is there anything I can do so we can merge this?

@fractallian
Copy link

We need this as well 🙏

@serniebanders
Copy link

Please

@pablomusumeci
Copy link

Please, can we get this one merged? It would be extremely helpful 🙏

@cjezinne
Copy link

@jaredhanson can we get this merged?

@cjezinne
Copy link

@pablomusumeci Here's a fork by @serniebanders:
"You can use this as a dependency: git+https://github.com/serniebanders/passport-google-oauth2.git"

@pablomusumeci
Copy link

@cjezinne thanks! Although, relying on an unofficial fork is not a future-proof solution 😢

@rjenkin
Copy link

rjenkin commented Feb 8, 2023

For anyone else with this issue, I've found a workaround to force passport-oauth2 to use oauth@0.10.0 by adding an override into my project's package.json:

    "overrides": {
        "oauth": "~0.10.0"
    }

When the node_modules were deleted/reinstalled, passport-oauth2 was using version 0.10.0:

$ npm list oauth
server@1.0.0 /Users/.../webserver
└─┬ passport-oauth2@1.6.1
  └── oauth@0.10.0

Just keep in mind that this code should be removed if passport-oauth2 is ever upgraded in future to use a higher version of oauth, e.g 0.11.0 which currently doesn't exist.

@pedrohma
Copy link

@rjenkin you are the man

@pedrohma
Copy link

@jaredhanson please merge this PR

@grigored
Copy link

grigored commented Jun 4, 2023

For anyone else with this issue, I've found a workaround to force passport-oauth2 to use oauth@0.10.0 by adding an override into my project's package.json:

    "overrides": {
        "oauth": "~0.10.0"
    }

When the node_modules were deleted/reinstalled, passport-oauth2 was using version 0.10.0:

$ npm list oauth
server@1.0.0 /Users/.../webserver
└─┬ passport-oauth2@1.6.1
  └── oauth@0.10.0

Just keep in mind that this code should be removed if passport-oauth2 is ever upgraded in future to use a higher version of oauth, e.g 0.11.0 which currently doesn't exist.

Thanks a lot for this fix! For yarn users, instead of overrides you should use resolutions. Also, if you are using yarn workspaces make sure to put this in the root package.json

@jaredhanson jaredhanson merged commit cff8b19 into jaredhanson:master Feb 2, 2024
@jaredhanson
Copy link
Owner

Merged and published as passport-oauth2@1.8.0. Thanks!

@Quentin-Danjou Quentin-Danjou deleted the patch-1 branch February 7, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet