Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pretty-error? #1040

Closed
honzajavorek opened this issue Aug 31, 2018 · 6 comments
Closed

Replace pretty-error? #1040

honzajavorek opened this issue Aug 31, 2018 · 6 comments
Labels

Comments

@honzajavorek
Copy link

I don't know how important pretty-error is for the functionality of html-webpack-plugin, but it has some serious licensing issues down its dependencies: AriaMinaei/RenderKid#8

It seems to me @fb55's dependencies and the css-select project act as a single point of failure in such a successful project as html-webpack-plugin is. Even if you don't care about licensing, it's apparently naive to expect the dependencies will ever get updated, bugs fixed, etc.

@jantimon
Copy link
Owner

jantimon commented Sep 4, 2018

The html-webpack-plugin allows you to use very complex templates and even pure javascript code as a template (just use a .js file). If the evaluation of this code fails I tried to provide as much useful information as possible and came across pretty error.

However the current pretty error integration has definitely some room for improvements - maybe @AriaMinaei could take a look at the current implementation.

@honzajavorek Can you recommend a similar solution?

@AriaMinaei
Copy link

This is important. I'm looking for a replacement for css-select now. Will ping you guys here once it's done.

@char0n
Copy link

char0n commented Sep 6, 2018

@AriaMinaei thank you very much

@jantimon
Copy link
Owner

@AriaMinaei any news? :)

@AriaMinaei
Copy link

Not yet. Trying to find the time to do this :)

@stale
Copy link

stale bot commented Mar 14, 2019

This issue had no activity for at least half a year. It's subject to automatic issue closing if there is no activity in the next 15 days.

@stale stale bot added the wontfix label Mar 14, 2019
@stale stale bot closed this as completed Mar 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants