New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pylance-version
option
#63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this seems good; you will need to also update the README
as well to document the option, and maybe add an example.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 3 3
Lines 191 457 +266
Branches 45 98 +53
==========================================
+ Hits 191 457 +266
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good to me; thanks for sending this. Any other remaining concerns? If not, I'll cut a release for this.
I should be sending a matching PR to pyright-python today. In the off-chance that Robert has any feedback that somehow impacts this change, would you mind holding off on merging this until he approves my PR? |
I'm now out at a morale event so can't do it now anyway; just let me know when you're ready and I'll merge and release it! |
61ee233
to
2d86847
Compare
FYI, I'm still waiting for feedback on my pyright-python PR. I'm guessing Robert is on vacation. He was quite responsive a couple weeks ago, but has been silent over the past week. I'll let you know if this can be merged as soon as I hear back from him on RobertCraigie/pyright-python#230. |
@jakebailey, the |
Released in v1.8.0. Thanks! |
Part of microsoft/pylance-release#4927
Added a new
pylance-version
option which can belatest-release
,latest-prerelease
, or a specific Pylance version number like2023.11.11
.When
pylance-version
is provided andversion
is not, we'll leverage the Pylance release metadata JSON files in https://github.com/microsoft/pylance-release/tree/main/releases to determine which version of Pyright is included in that Pylance release, and then download and run that Pyright build as usual.