Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pylance-version option #63

Merged
merged 19 commits into from Nov 29, 2023
Merged

Conversation

debonte
Copy link
Contributor

@debonte debonte commented Nov 8, 2023

Part of microsoft/pylance-release#4927

Added a new pylance-version option which can be latest-release, latest-prerelease, or a specific Pylance version number like 2023.11.11.

When pylance-version is provided and version is not, we'll leverage the Pylance release metadata JSON files in https://github.com/microsoft/pylance-release/tree/main/releases to determine which version of Pyright is included in that Pylance release, and then download and run that Pyright build as usual.

src/helpers.ts Outdated Show resolved Hide resolved
Copy link
Owner

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this seems good; you will need to also update the README as well to document the option, and maybe add an example.

src/helpers.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4696e5) 100.00% compared to head (e10e928) 100.00%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #63    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            3         3            
  Lines          191       457   +266     
  Branches        45        98    +53     
==========================================
+ Hits           191       457   +266     
Files Coverage Δ
src/helpers.ts 100.00% <100.00%> (ø)
src/schema.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me; thanks for sending this. Any other remaining concerns? If not, I'll cut a release for this.

@debonte
Copy link
Contributor Author

debonte commented Nov 8, 2023

Any other remaining concerns?

I should be sending a matching PR to pyright-python today. In the off-chance that Robert has any feedback that somehow impacts this change, would you mind holding off on merging this until he approves my PR?

@jakebailey
Copy link
Owner

I'm now out at a morale event so can't do it now anyway; just let me know when you're ready and I'll merge and release it!

@debonte
Copy link
Contributor Author

debonte commented Nov 15, 2023

FYI, I'm still waiting for feedback on my pyright-python PR. I'm guessing Robert is on vacation. He was quite responsive a couple weeks ago, but has been silent over the past week. I'll let you know if this can be merged as soon as I hear back from him on RobertCraigie/pyright-python#230.

@debonte
Copy link
Contributor Author

debonte commented Nov 29, 2023

@jakebailey, the pyright-python PR was merged without any changes that would impact this PR. So please merge this at your convenience. Thanks!

@jakebailey jakebailey merged commit 4f86b1c into jakebailey:main Nov 29, 2023
9 checks passed
@jakebailey
Copy link
Owner

Released in v1.8.0. Thanks!

@debonte debonte deleted the pylanceVersion branch November 29, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants