Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "version: PATH" to pull pyright from $PATH #107

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Conversation

jakebailey
Copy link
Owner

@jakebailey jakebailey commented Apr 10, 2024

version: PATH instructs the action to instead look on $PATH for pyright. This is useful in situations where dev dependencies already install pyright, e.g. via PyPI.

- run: |
    python -m venv .venv
    source .venv/bin/activate
    pip install -r dev-requirements.txt # includes pyright
- run: echo "$PWD/.venv/bin" >> $GITHUB_PATH

- uses: jakebailey/pyright-action@v2
  with:
    version: PATH

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a9434fd) to head (6661384).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #107   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          590       633   +43     
  Branches       118       127    +9     
=========================================
+ Hits           590       633   +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakebailey jakebailey changed the title Add "version: path" to pull pyright from $PATH Add "version: PATH" to pull pyright from $PATH Apr 10, 2024
@jakebailey jakebailey marked this pull request as ready for review April 10, 2024 17:40
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@jakebailey jakebailey merged commit 32e0647 into main Apr 11, 2024
12 checks passed
@jakebailey jakebailey deleted the version-path branch April 11, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant