Add safety slot before variable for probe array

[Godin]

Fixes #767
Fixes #1412
Fixes #1429

[Jacks0N23]

I test it locally and it fix my problem from this issue
Please, can you merge it?

[AlexeyKorshun]

can you merge this fix?

[Godin]

@Jacks0N23 @AlexeyKorshun

can you merge it?

unfortunately not yet - see #893 (comment)

[marchof]

@Godin Given the complexity of inserting the probe array somewhere "in the middle" we might consider simply adding it to the end. This will increase the byte code size because it will be less likely that ALOAD_0 ... ALOAD_3 can be used but has probably no performance impact. WDYT?

[Godin]

@marchof regarding #893 (comment)

has probably no performance impact

I'm not so sure, are you? 😉

This will increase the byte code size

And method size is limited 😉

simply adding it to the end

I wouldn't call it "simply" - ProbeInserter#visitMaxs can not be used to determine position, because it is invoked after other ProbeInserter visit methods (such as ProbeInserter#visitVarInsn) that already should know position, so we will need to find another place/way to compute position. Which to me sounds more complex than a modification of this PR that will fix #893 (comment), and especially since I already have this modification and will publish it shortly 😉

[Godin]

@marchof I rebased this PR and fixed the problem described in #893 (comment), it still lacks in-code comments requested in #893 (comment) and the changelog entry, but maybe you already can review what else needs to be tweaked in the implementation?

---

Fun fact: the issue can be reproduced by using Kotlin compiler versions starting from released 7 years ago 1.0 🙈 😆 up to the latest as of today released 1.8.21 - enough to declare an inline function with a default value for a parameter and body that immediately declares a variable of Long or Double type

inline fun example(x: Int = 0): Double {
    val y: Double = 0.0
    return x + y
}

fun main(args: Array<String>) {
}

[Godin]

@marchof I added comments and updated changelog, so IMO this can be merged 🎉