Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KotlinDefaultArgumentsFilter for the case of more than 32 parameters #1556

Merged
merged 6 commits into from Dec 18, 2023

Conversation

Godin
Copy link
Member

@Godin Godin commented Dec 13, 2023

Fixes #1546

@Godin Godin added this to the 0.8.12 milestone Dec 13, 2023
@Godin Godin self-assigned this Dec 13, 2023
@Godin Godin added this to Implementation in Current work items via automation Dec 13, 2023
@Godin Godin added this to Awaiting triage in Filtering via automation Dec 13, 2023
@Godin Godin moved this from Awaiting triage to In Progress in Filtering Dec 13, 2023
@Godin Godin force-pushed the kotlin_default_arguments_issue_1546 branch from cd2e0a0 to d553db6 Compare December 13, 2023 13:33
@Godin Godin moved this from Implementation to Review in Current work items Dec 14, 2023
@Godin Godin marked this pull request as ready for review December 14, 2023 13:27
@Godin Godin requested a review from marchof December 14, 2023 15:33
@Godin Godin marked this pull request as draft December 14, 2023 18:58
@Godin Godin moved this from Review to Implementation in Current work items Dec 14, 2023
@Godin Godin removed the request for review from marchof December 14, 2023 18:59
@Godin Godin force-pushed the kotlin_default_arguments_issue_1546 branch from 07630a0 to e0a66af Compare December 15, 2023 08:32
@Godin Godin force-pushed the kotlin_default_arguments_issue_1546 branch from e0a66af to b653a9b Compare December 15, 2023 08:39
@Godin Godin marked this pull request as ready for review December 15, 2023 09:47
@Godin Godin moved this from Implementation to Review in Current work items Dec 15, 2023
@Godin Godin requested a review from marchof December 15, 2023 09:47
@Godin Godin requested a review from marchof December 18, 2023 10:52
@marchof marchof merged commit eb30f17 into jacoco:master Dec 18, 2023
24 checks passed
Filtering automation moved this from In Progress to Done Dec 18, 2023
Current work items automation moved this from Review to Done Dec 18, 2023
ndwlocatieservices added a commit to ndwnu/nls-routing-map-matcher that referenced this pull request Apr 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [nu.ndw.nls.geometry:nls-geometry](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | compile | patch | `2.0.3` -> `2.0.4` |
| [commons-io:commons-io](https://commons.apache.org/proper/commons-io/) ([source](https://gitbox.apache.org/repos/asf?p=commons-io.git)) | compile | minor | `2.15.1` -> `2.16.1` |
| [org.jacoco:jacoco-maven-plugin](https://www.jacoco.org/jacoco/trunk/doc/maven.html) ([source](https://github.com/jacoco/jacoco)) | build | patch | `0.8.11` -> `0.8.12` |
| [com.google.guava:guava](https://github.com/google/guava) | compile | minor | `33.0.0-jre` -> `33.1.0-jre` |
| [org.codehaus.janino:janino](http://janino-compiler.github.io/janino/) ([source](https://github.com/janino-compiler/janino)) | compile | patch | `3.1.11` -> `3.1.12` |
| [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.2.3` -> `3.2.5` |

---

### Release Notes

<details>
<summary>spring-projects/spring-boot (nu.ndw.nls.geometry:nls-geometry)</summary>

### [`v2.0.4`](spring-projects/spring-boot@v2.0.3.RELEASE...v2.0.4.RELEASE)

[Compare Source](spring-projects/spring-boot@v2.0.3.RELEASE...v2.0.4.RELEASE)

</details>

<details>
<summary>jacoco/jacoco (org.jacoco:jacoco-maven-plugin)</summary>

### [`v0.8.12`](https://github.com/jacoco/jacoco/releases/tag/v0.8.12): 0.8.12

[Compare Source](jacoco/jacoco@v0.8.11...v0.8.12)

#### New Features

-   JaCoCo now officially supports Java 22 (GitHub [#&#8203;1596](jacoco/jacoco#1596)).
-   Experimental support for Java 23 class files (GitHub [#&#8203;1553](jacoco/jacoco#1553)).

#### Fixed bugs

-   Branches added by the Kotlin compiler for functions with default arguments and having more than 32 parameters are filtered out during generation of report (GitHub [#&#8203;1556](jacoco/jacoco#1556)).
-   Branch added by the Kotlin compiler version 1.5.0 and above for reading from lateinit property is filtered out during generation of report (GitHub [#&#8203;1568](jacoco/jacoco#1568)).

#### Non-functional Changes

-   JaCoCo now depends on ASM 9.7 (GitHub [#&#8203;1600](jacoco/jacoco#1600)).

</details>

<details>
<summary>janino-compiler/janino (org.codehaus.janino:janino)</summary>

### [`v3.1.12`](janino-compiler/janino@v3.1.11...v3.1.12)

[Compare Source](janino-compiler/janino@v3.1.11...v3.1.12)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Filtering
  
Done
Development

Successfully merging this pull request may close these issues.

Data class with >32 properties shows missing branch coverage
2 participants