Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to ASM website #1515

Merged
merged 1 commit into from Oct 2, 2023
Merged

Conversation

@Godin Godin added this to the 0.8.11 milestone Sep 28, 2023
@Godin Godin requested a review from marchof September 28, 2023 13:26
@Godin Godin added this to Implementation in Current work items via automation Sep 28, 2023
@Godin Godin self-assigned this Sep 28, 2023
@Godin Godin moved this from Implementation to Review in Current work items Sep 28, 2023
@@ -415,7 +415,7 @@ <h2>Performance</h2>
<h2>References</h2>

<ul>
<li><a href="http://asm.objectweb.org/">ASM byte code library</a> by Eric Bruneton at al.</li>
<li><a href="https://asm.ow2.io/">ASM byte code library</a> by Eric Bruneton at al.</li>
<li><a href="http://andrei.gmxhome.de/bytecode/index.html">Bytecode Outline Plug-In</a> by Andrei Loskutov</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it it, this link is also outdated.

Suggested change
<li><a href="http://andrei.gmxhome.de/bytecode/index.html">Bytecode Outline Plug-In</a> by Andrei Loskutov</li>
<li><a href="https://marketplace.eclipse.org/content/bytecode-outline">Bytecode Outline Plug-In</a> by Andrei Loskutov</li>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think separate changes look cleaner/nicer - #1519

Copy link
Member

@marchof marchof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASM is good! I found another broken link, which we could fix right now or in a separate PR.

@Godin Godin merged commit 6798260 into jacoco:master Oct 2, 2023
23 checks passed
Current work items automation moved this from Review to Done Oct 2, 2023
@Godin Godin deleted the fix_links_to_asm_website branch October 2, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants