Maven 3.9.2 should not produce warnings for jacoco-maven-plugin #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Godin
force-pushed
the
maven_3_9_2_should_not_produce_warnings_for_jacoco-maven-plugin
branch
from
fce3847
to
f0e1124
Compare
Godin
force-pushed
the
maven_3_9_2_should_not_produce_warnings_for_jacoco-maven-plugin
branch
from
f0e1124
to
ef6fb48
Compare
marchof
reviewed
May 25, 2023
| <li>jacoco-maven-plugin now requires at least Java 8 | ||
| (GitHub <a href="https://github.com/jacoco/jacoco/issues/1466">#1466</a>).</li> | ||
| (GitHub <a href="https://github.com/jacoco/jacoco/issues/1466">#1466</a>, | ||
| <a href="https://github.com/jacoco/jacoco/issues/1468">#1468</a>).</li> |
There was a problem hiding this comment.
Is it intentional that the PR is listed twice? If so maybe the commit message should be extended to explain the dependency on Java 8.
There was a problem hiding this comment.
@marchof Yes - it is intentional in order to express the link between these changes in the changelog.
I updated the commit message.
Note that `org.apache.maven.shared:file-management` version `3.1.0` requires Java 8.
Godin
force-pushed
the
maven_3_9_2_should_not_produce_warnings_for_jacoco-maven-plugin
branch
from
ef6fb48
to
0ed6608
Compare
marchof
approved these changes
May 26, 2023
Godin
deleted the
maven_3_9_2_should_not_produce_warnings_for_jacoco-maven-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.