Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require at least JDK 11 for the build #1413

Merged
merged 1 commit into from Mar 16, 2023
Merged

Require at least JDK 11 for the build #1413

merged 1 commit into from Mar 16, 2023

Conversation

Godin
Copy link
Member

@Godin Godin commented Mar 15, 2023

No description provided.

@Godin Godin self-assigned this Mar 15, 2023
@Godin Godin added this to Implementation in Current work items via automation Mar 15, 2023
@Godin Godin modified the milestones: 0.8.10, 0.8.9 Mar 15, 2023
@Godin Godin force-pushed the require_jdk11_for_build branch 2 times, most recently from a981c72 to 5cea901 Compare March 16, 2023 00:03
@Godin Godin marked this pull request as ready for review March 16, 2023 00:55
@Godin
Copy link
Member Author

Godin commented Mar 16, 2023

@marchof I wanted to add a validation test for JEP 432 Record Patterns, but to format them

  • either need to update Eclipse Formatter to the latest version, which like Eclipse Compiler requires JDK 11 (see Upgrade ECJ from 3.12.1 to 3.32.0 #1404)
  • or use a different version of formatter in different modules
  • or disable automatic formatting in the corresponding module

I propose simply go with option 1 and require JDK 11 to start Maven. After this is done, I'll do a separate PR for the update of Eclipse Formatter.

@Godin Godin moved this from Implementation to Review in Current work items Mar 16, 2023
@Godin Godin requested a review from marchof March 16, 2023 00:56
@marchof marchof merged commit 4fca868 into master Mar 16, 2023
Current work items automation moved this from Review to Done Mar 16, 2023
@marchof marchof deleted the require_jdk11_for_build branch March 16, 2023 06:38
ndwnu pushed a commit to ndwnu/nls-routing-map-matcher that referenced this pull request Apr 10, 2024
Merged PR 23691: Update all non-major dependencies
c1db274 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [org.apache.maven.plugins:maven-compiler-plugin](https://maven.apache.org/plugins/) | build | minor | `3.10.1` -> `3.11.0` |
| [org.jacoco:jacoco-maven-plugin](https://www.jacoco.org/jacoco/trunk/doc/maven.html) ([source](https://github.com/jacoco/jacoco)) | build | patch | `0.8.8` -> `0.8.10` |
| [com.graphhopper:graphhopper-map-matching](https://www.graphhopper.com) ([source](https://github.com/graphhopper/graphhopper)) | compile | patch | `7.0` -> `7.0-testgithub6` |
| [com.graphhopper:graphhopper-core](https://www.graphhopper.com) ([source](https://github.com/graphhopper/graphhopper)) | compile | patch | `7.0` -> `7.0-testgithub6` |
| [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.0.5` -> `3.0.6` |

---

### Release Notes

<details>
<summary>jacoco/jacoco</summary>

### [`v0.8.10`](https://github.com/jacoco/jacoco/releases/tag/v0.8.10): 0.8.10

[Compare Source](jacoco/jacoco@v0.8.9...v0.8.10)

#### Fixed bugs

-   Agent should not require configuration of permissions for `SecurityManager` outside of its `codeBase` (GitHub [#&#8203;1425](jacoco/jacoco#1425)).

### [`v0.8.9`](https://github.com/jacoco/jacoco/releases/tag/v0.8.9): 0.8.9

[Compare Source](jacoco/jacoco@v0.8.8...v0.8.9)

#### New Features

-   JaCoCo now officially supports Java 19 and 20 (GitHub [#&#8203;1371](jacoco/jacoco#1371), [#&#8203;1386](jacoco/jacoco#1386)).
-   Experimental support for Java 21 class files (GitHub [#&#8203;1386](jacoco/jacoco#1386)).
-   Add parameter to include the current project in the `report-aggregate` Maven goal (GitHub [#&#8203;1007](jacoco/jacoco#1007)).
-   Component accessors generated by the Java compilers for records are filtered out during generation of report. Contributed by Tesla Zhang (GitHub [#&#8203;1393](jacoco/jacoco#1393)).

#### Fixed bugs

-   Agent should not open `java.lang` package to unnamed module of the application class loader (GitHub [#&#8203;1334](jacoco/jacoco#1334)).

#### Non-functional Changes

-   JaCoCo now depends on ASM 9.5 (GitHub [#&#8203;1299](jacoco/jacoco#1299), [#&#8203;1368](jacoco/jacoco#1368), [#&#8203;1416](jacoco/jacoco#1416)).
-   JaCoCo build now requires JDK 11 (GitHub [#&#8203;1413](jacoco/jacoco#1413)).

</details>

<details>
<summary>graphhopper/graphhopper</summary>

### [`v7.0-pre2`](graphhopper/graphhopper@7.0-pre1...7.0-pre2)

[Compare Source](graphhopper/graphhopper@7.0-pre1...7.0-pre2...
ndwlocatieservices added a commit to ndwnu/nls-routing-map-matcher that referenced this pull request Apr 16, 2024
@ndwlocatieservices
Merged PR 23691: Update all non-major dependencies
a7d7cf6 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [org.apache.maven.plugins:maven-compiler-plugin](https://maven.apache.org/plugins/) | build | minor | `3.10.1` -> `3.11.0` |
| [org.jacoco:jacoco-maven-plugin](https://www.jacoco.org/jacoco/trunk/doc/maven.html) ([source](https://github.com/jacoco/jacoco)) | build | patch | `0.8.8` -> `0.8.10` |
| [com.graphhopper:graphhopper-map-matching](https://www.graphhopper.com) ([source](https://github.com/graphhopper/graphhopper)) | compile | patch | `7.0` -> `7.0-testgithub6` |
| [com.graphhopper:graphhopper-core](https://www.graphhopper.com) ([source](https://github.com/graphhopper/graphhopper)) | compile | patch | `7.0` -> `7.0-testgithub6` |
| [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.0.5` -> `3.0.6` |

---

### Release Notes

<details>
<summary>jacoco/jacoco</summary>

### [`v0.8.10`](https://github.com/jacoco/jacoco/releases/tag/v0.8.10): 0.8.10

[Compare Source](jacoco/jacoco@v0.8.9...v0.8.10)

#### Fixed bugs

-   Agent should not require configuration of permissions for `SecurityManager` outside of its `codeBase` (GitHub [#&#8203;1425](jacoco/jacoco#1425)).

### [`v0.8.9`](https://github.com/jacoco/jacoco/releases/tag/v0.8.9): 0.8.9

[Compare Source](jacoco/jacoco@v0.8.8...v0.8.9)

#### New Features

-   JaCoCo now officially supports Java 19 and 20 (GitHub [#&#8203;1371](jacoco/jacoco#1371), [#&#8203;1386](jacoco/jacoco#1386)).
-   Experimental support for Java 21 class files (GitHub [#&#8203;1386](jacoco/jacoco#1386)).
-   Add parameter to include the current project in the `report-aggregate` Maven goal (GitHub [#&#8203;1007](jacoco/jacoco#1007)).
-   Component accessors generated by the Java compilers for records are filtered out during generation of report. Contributed by Tesla Zhang (GitHub [#&#8203;1393](jacoco/jacoco#1393)).

#### Fixed bugs

-   Agent should not open `java.lang` package to unnamed module of the application class loader (GitHub [#&#8203;1334](jacoco/jacoco#1334)).

#### Non-functional Changes

-   JaCoCo now depends on ASM 9.5 (GitHub [#&#8203;1299](jacoco/jacoco#1299), [#&#8203;1368](jacoco/jacoco#1368), [#&#8203;1416](jacoco/jacoco#1416)).
-   JaCoCo build now requires JDK 11 (GitHub [#&#8203;1413](jacoco/jacoco#1413)).

</details>

<details>
<summary>graphhopper/graphhopper</summary>

### [`v7.0-pre2`](graphhopper/graphhopper@7.0-pre1...7.0-pre2)

[Compare Source](graphhopper/graphhopper@7.0-pre1...7.0-pre2...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels
component: build
Projects
Current work items
  
Done
Milestone
0.8.9
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Godin @marchof