New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ECJ from 3.12.1 to 3.32.0 #1404
Conversation
3e5c0e0
to
71096c4
Compare
@@ -267,18 +267,22 @@ <h2>Compilation and testing with different JDKs</h2> | |||
<li><code>mvn clean verify -Djdk.version=6 -Dbytecode.version=6</code></li> | |||
<li><code>mvn clean verify -Djdk.version=7 -Dbytecode.version=7</code></li> | |||
<li><code>mvn clean verify -Djdk.version=8 -Dbytecode.version=8</code></li> | |||
<li><code>mvn clean verify -Djdk.version=8 -Dbytecode.version=8 -Decj</code></li> | |||
<li><code>mvn clean verify -Djdk.version=8 -Dbytecode.version=8</code></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the whole line should be deleted now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, don't know why missed this 😆 done
<li><code>mvn clean verify -Djdk.version=9 -Dbytecode.version=9</code></li> | ||
<li><code>mvn clean verify -Djdk.version=10 -Dbytecode.version=10</code></li> | ||
<li><code>mvn clean verify -Djdk.version=11 -Dbytecode.version=11</code></li> | ||
<li><code>mvn clean verify -Djdk.version=11 -Dbytecode.version=11 -Decj</code></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While Java 11 should now be listed twice: With and without -Decj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding more JDK versions for ECJ! Code looks good for me, I only think there are duplicate/missing entries in build.html
.
Version `4.6.1` of previously used artifact `org.eclipse.jdt:ecj` was actually version of Eclipse IDE. This version supports source/target from Java 1.1 up to 19. Also note that starting from version `3.27.0` ECJ requires Java 11 for execution.
Version
4.6.1
of previously used artifactorg.eclipse.jdt:ecj
was actually version of Eclipse IDE.This version supports source/target from Java 1.1 up to 19.
Also note that starting from version
3.27.0
ECJ requires Java 11 for execution.