RecordsFilter should filter out accessors #1393

ice1000 · 2023-01-18T23:52:37Z

This PR fixes #1215, but it's not tested. I need help on authoring tests.

…es!!

ice1000 · 2023-01-19T01:59:06Z

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project org.jacoco.core.test.validation.java16: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/vsts/work/1/s/org.jacoco.core.test.validation.java16/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project org.jacoco.core.test.validation.java16: There are test failures.

Please refer to /home/vsts/work/1/s/org.jacoco.core.test.validation.java16/target/surefire-reports for the individual test results.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)

Test reports??

ice1000 · 2023-01-19T02:08:18Z

Tried to fix, let's see what happens...

ice1000 · 2023-01-19T04:50:32Z

Nice!! All tests passed.

org.jacoco.core/src/org/jacoco/core/internal/analysis/filter/RecordsFilter.java

ice1000 · 2023-01-28T21:36:25Z

@marchof I'm done, please retake a look!

ice1000 · 2023-01-28T21:37:37Z

The CI is failing for unknown reasons.

ice1000 · 2023-01-28T21:38:30Z

Starting: Setup JDK
==============================================================================
Task         : Bash
Description  : Run a Bash script on macOS, Linux, or Windows
Version      : 3.214.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
==============================================================================
Generating script.
========================== Starting Command Output ===========================
/bin/bash /home/vsts/work/_temp/cef2ae88-bd3a-416e-a0d6-c49f098fa19b.sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
100  7073  100  7073    0     0   4724      0  0:00:01  0:00:01 --:--:--  4724

gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
##[error]Bash exited with code '2'.
Finishing: Setup JDK

marchof · 2023-01-31T15:45:50Z

@ice1000 Our CI (and the internet in general) is a bit flaky. Sometime JDK downloads do fail. As you have green builds for most of the JDKs don't worry for now. With your next commit it will probably work again.

ice1000 · 2023-01-31T15:56:15Z

@ice1000 Our CI (and the internet in general) is a bit flaky. Sometime JDK downloads do fail. As you have green builds for most of the JDKs don't worry for now. With your next commit it will probably work again.

Do you expect a next commit? Is there anything else I can do to get this merged? 🔮

marchof · 2023-01-31T17:04:33Z

@ice1000 We need more commits to finalize this: Can you please add unit test to RecordsFilterTest. You find lots of unit tests in the same package that you can use as reference.

ice1000 · 2023-01-31T19:06:31Z

@marchof what do you think about the new two tests I've added? Do I need more?

org.jacoco.core.test/src/org/jacoco/core/internal/analysis/filter/RecordsFilterTest.java

ice1000 · 2023-02-01T21:44:18Z

@marchof done! I'm adding one more "should_not" test....

ice1000 · 2023-02-01T21:49:09Z

Nice!!!

marchof · 2023-02-02T17:48:36Z

Looks good now! I would like to fix the change log. Can you please give me write access to your fork? See

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

marchof · 2023-02-02T17:51:37Z

Alternatively please add the following block to changes.html (as the last point under New Features:

  <li>Component accessors generated by the Java compilers for records are filtered
      out during generation of report. Contributed by Tesla Zhang‮
      (GitHub <a href="https://github.com/jacoco/jacoco/issues/1393">#1393</a>).</li>

ice1000 · 2023-02-02T19:22:57Z

I don't see the button in the tutorial. I invited you as a collaborator: https://github.com/ice1k/jacoco/invitations

marchof · 2023-02-03T06:53:50Z

I don't see the button in the tutorial. I invited you as a collaborator: https://github.com/ice1k/jacoco/invitations

Probably this is because the repository belongs to a different user (ice1000 vs ice1k). As a collaborator I was now able to push.

ice1000 · 2023-02-03T06:54:02Z

Merge?

marchof · 2023-02-03T06:54:18Z

@Godin Can you please have a look?

marchof · 2023-02-03T06:55:27Z

Merge?

Not yet, a second committer (@Godin) will now do the final review.

org.jacoco.core/src/org/jacoco/core/internal/analysis/filter/RecordsFilter.java

org.jacoco.doc/docroot/doc/changes.html

ice1000 · 2023-02-05T02:20:11Z

@Godin all done, please retake a look!

ice1000 · 2023-02-06T21:17:07Z

ping 👻

Godin · 2023-02-06T23:54:58Z

@ice1000 We are working on this project in our spare time when we have it. We will appreciate it if you'll let us manage our time by ourselves - no need to send pings.

forresthopkinsa · 2023-02-07T00:23:50Z

You love to see it. Thanks for the work folks

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.maven.plugins:maven-compiler-plugin](https://maven.apache.org/plugins/) | build | minor | `3.10.1` -> `3.11.0` | | [org.jacoco:jacoco-maven-plugin](https://www.jacoco.org/jacoco/trunk/doc/maven.html) ([source](https://github.com/jacoco/jacoco)) | build | patch | `0.8.8` -> `0.8.10` | | [com.graphhopper:graphhopper-map-matching](https://www.graphhopper.com) ([source](https://github.com/graphhopper/graphhopper)) | compile | patch | `7.0` -> `7.0-testgithub6` | | [com.graphhopper:graphhopper-core](https://www.graphhopper.com) ([source](https://github.com/graphhopper/graphhopper)) | compile | patch | `7.0` -> `7.0-testgithub6` | | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `3.0.5` -> `3.0.6` | --- ### Release Notes <details> <summary>jacoco/jacoco</summary> ### [`v0.8.10`](https://github.com/jacoco/jacoco/releases/tag/v0.8.10): 0.8.10 [Compare Source](jacoco/jacoco@v0.8.9...v0.8.10) #### Fixed bugs - Agent should not require configuration of permissions for `SecurityManager` outside of its `codeBase` (GitHub [#1425](jacoco/jacoco#1425)). ### [`v0.8.9`](https://github.com/jacoco/jacoco/releases/tag/v0.8.9): 0.8.9 [Compare Source](jacoco/jacoco@v0.8.8...v0.8.9) #### New Features - JaCoCo now officially supports Java 19 and 20 (GitHub [#1371](jacoco/jacoco#1371), [#1386](jacoco/jacoco#1386)). - Experimental support for Java 21 class files (GitHub [#1386](jacoco/jacoco#1386)). - Add parameter to include the current project in the `report-aggregate` Maven goal (GitHub [#1007](jacoco/jacoco#1007)). - Component accessors generated by the Java compilers for records are filtered out during generation of report. Contributed by Tesla Zhang (GitHub [#1393](jacoco/jacoco#1393)). #### Fixed bugs - Agent should not open `java.lang` package to unnamed module of the application class loader (GitHub [#1334](jacoco/jacoco#1334)). #### Non-functional Changes - JaCoCo now depends on ASM 9.5 (GitHub [#1299](jacoco/jacoco#1299), [#1368](jacoco/jacoco#1368), [#1416](jacoco/jacoco#1416)). - JaCoCo build now requires JDK 11 (GitHub [#1413](jacoco/jacoco#1413)). </details> <details> <summary>graphhopper/graphhopper</summary> ### [`v7.0-pre2`](graphhopper/graphhopper@7.0-pre1...7.0-pre2) [Compare Source](graphhopper/graphhopper@7.0-pre1...7.0-pre2...

Implement filter for record field accessors

b8869ac

ice1000 mentioned this pull request Jan 18, 2023

Filter of Java 16 record accessors #1215

Closed

ice1000 added 5 commits January 18, 2023 18:58

Modify existing test, which happens to already have all my wanted cas…

96a4d72

…es!!

Fix fmt (hopefully)

f3664f5

Fix fmt again (hopefully)

ef7e04e

Fix fmt the third time (hopefully)

886b721

Fix fmt the fourth time (IntelliJ's problem)

92156f0

Why

cd9ef7b

forresthopkinsa reviewed Jan 24, 2023

View reviewed changes

org.jacoco.core/src/org/jacoco/core/internal/analysis/filter/RecordsFilter.java Outdated Show resolved Hide resolved

ice1000 added 3 commits January 27, 2023 23:05

Address comments

1466367

Remove unused imports

d83901e

Fix fmt

969f894

ice1000 added 2 commits January 31, 2023 13:59

Add record filter tests

a3ba400

Merge branch 'master' into master

911c0ad

marchof reviewed Feb 1, 2023

View reviewed changes

org.jacoco.core.test/src/org/jacoco/core/internal/analysis/filter/RecordsFilterTest.java Outdated Show resolved Hide resolved

marchof reviewed Feb 1, 2023

View reviewed changes

org.jacoco.core.test/src/org/jacoco/core/internal/analysis/filter/RecordsFilterTest.java Outdated Show resolved Hide resolved

Address comments

3c6a837

Add test

7cc291b

Add change log entry

3f83007

marchof requested a review from Godin February 3, 2023 06:54

Godin requested changes Feb 5, 2023

View reviewed changes

org.jacoco.core/src/org/jacoco/core/internal/analysis/filter/RecordsFilter.java Outdated Show resolved Hide resolved

org.jacoco.doc/docroot/doc/changes.html Outdated Show resolved Hide resolved

Godin added the component: core.filters label Feb 5, 2023

Godin added this to Awaiting triage in Filtering via automation Feb 5, 2023

Godin added this to the 0.8.9 milestone Feb 5, 2023

Godin added this to Implementation in Current work items via automation Feb 5, 2023

Godin moved this from Implementation to Review in Current work items Feb 5, 2023

Godin moved this from Awaiting triage to In Progress in Filtering Feb 5, 2023

Godin added the type: enhancement label Feb 5, 2023

Comments by @Godin

175ab37

Godin changed the title ~~Implement filter for record field accessors! (#1215)~~ RecordsFilter should filter out accessors Feb 6, 2023

Godin approved these changes Feb 6, 2023

View reviewed changes

Godin merged commit 77d7418 into jacoco:master Feb 6, 2023

Filtering automation moved this from In Progress to Done Feb 6, 2023

Current work items automation moved this from Review to Done Feb 6, 2023

Godin added the language: Java label Oct 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RecordsFilter should filter out accessors #1393

RecordsFilter should filter out accessors #1393

ice1000 commented Jan 18, 2023

ice1000 commented Jan 19, 2023

ice1000 commented Jan 19, 2023

ice1000 commented Jan 19, 2023

ice1000 commented Jan 28, 2023 •

edited

ice1000 commented Jan 28, 2023

ice1000 commented Jan 28, 2023

marchof commented Jan 31, 2023

ice1000 commented Jan 31, 2023

marchof commented Jan 31, 2023

ice1000 commented Jan 31, 2023

ice1000 commented Feb 1, 2023

ice1000 commented Feb 1, 2023

marchof commented Feb 2, 2023

marchof commented Feb 2, 2023

ice1000 commented Feb 2, 2023

marchof commented Feb 3, 2023

ice1000 commented Feb 3, 2023

marchof commented Feb 3, 2023

marchof commented Feb 3, 2023

ice1000 commented Feb 5, 2023

ice1000 commented Feb 6, 2023

Godin commented Feb 6, 2023

forresthopkinsa commented Feb 7, 2023

RecordsFilter should filter out accessors #1393

RecordsFilter should filter out accessors #1393

Conversation

ice1000 commented Jan 18, 2023

ice1000 commented Jan 19, 2023

ice1000 commented Jan 19, 2023

ice1000 commented Jan 19, 2023

ice1000 commented Jan 28, 2023 • edited

ice1000 commented Jan 28, 2023

ice1000 commented Jan 28, 2023

marchof commented Jan 31, 2023

ice1000 commented Jan 31, 2023

marchof commented Jan 31, 2023

ice1000 commented Jan 31, 2023

ice1000 commented Feb 1, 2023

ice1000 commented Feb 1, 2023

marchof commented Feb 2, 2023

marchof commented Feb 2, 2023

ice1000 commented Feb 2, 2023

marchof commented Feb 3, 2023

ice1000 commented Feb 3, 2023

marchof commented Feb 3, 2023

marchof commented Feb 3, 2023

ice1000 commented Feb 5, 2023

ice1000 commented Feb 6, 2023

Godin commented Feb 6, 2023

forresthopkinsa commented Feb 7, 2023

ice1000 commented Jan 28, 2023 •

edited