Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using hidden field in example #1860

Closed
wants to merge 1 commit into from
Closed

Stop using hidden field in example #1860

wants to merge 1 commit into from

Conversation

howardjohn
Copy link
Member

Fixes #909

@howardjohn howardjohn added the release-notes-none Indicates a PR that does not require release notes. label Jan 29, 2021
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 29, 2021
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2021
@howardjohn
Copy link
Member Author

/retest

linsun
linsun approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think may be fixed in your other PR?

@linsun
Copy link
Member

linsun commented Feb 19, 2021

#1885 is the other PR, should we close this @howardjohn ?

Feel free to release hold if I'm wrong.

@linsun linsun added the do-not-merge/hold Block automatic merging of a PR. label Feb 19, 2021
@howardjohn howardjohn closed this Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smawson smawson smawson approved these changes

@linsun linsun linsun approved these changes

@dcberg dcberg Awaiting requested review from dcberg

@duderino duderino Awaiting requested review from duderino

@louiscryan louiscryan Awaiting requested review from louiscryan

@nrjpoddar nrjpoddar Awaiting requested review from nrjpoddar

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. do-not-merge/hold Block automatic merging of a PR. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OutlierDetection documentation wrong for error types
5 participants
@howardjohn @istio-policy-bot @linsun @smawson @istio-testing