Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow individual settings overrides using environment variables #489

Closed
d-w-moore opened this issue Nov 9, 2023 · 5 comments
Closed

allow individual settings overrides using environment variables #489

d-w-moore opened this issue Nov 9, 2023 · 5 comments
Assignees
Milestone

Comments

@d-w-moore
Copy link
Collaborator

d-w-moore commented Nov 9, 2023

A variable like, for instance:

PYTHON_IRODSCLIENT_CONFIG__DATA_OBJECTS__AUTO_CLOSE

could be used to override the value of:

data_objects.auto_close
@d-w-moore
Copy link
Collaborator Author

d-w-moore commented Nov 9, 2023

The most likely, or sole, application of this would be during (actually just following) autoload of the settings file.

@korydraughn
Copy link
Contributor

You're saying environment variables should override options in the settings file?

@d-w-moore
Copy link
Collaborator Author

d-w-moore commented Nov 9, 2023

Yes.

@d-w-moore
Copy link
Collaborator Author

d-w-moore commented Nov 9, 2023

You're saying environment variables should override options in the settings file?

Yep, I'm thinking of it as a line-item tweak capability, if/when necessary. I could imagine it being needed in rare cases. The settings file itself could be distributed in networks where other-than-default settings are (widely) needed. The environment would be a level of tweak above that, not necessarily commonly (or ever) used, but there if critically needed.

@korydraughn
Copy link
Contributor

That makes sense.

The settings file becomes the common way to configure things and environment variables give users a way to quickly override things if absolutely needed.

d-w-moore added a commit to d-w-moore/python-irodsclient that referenced this issue Jan 9, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…gs during autoload
d-w-moore added a commit to d-w-moore/python-irodsclient that referenced this issue Jan 9, 2024
@alanking alanking closed this as completed Jan 9, 2024
d-w-moore added a commit to d-w-moore/python-irodsclient that referenced this issue Jan 12, 2024
@trel trel added this to the 2.0.0 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants