Fix autosuggestions in multi-line mode, vi command mode delay #13991
Conversation
krassowski
added
bug
autosuggestions
|
+1, I pushed a commit that use module level I'll let you review the last commit and merge if you are ok with it. |
| @@ -186,12 +186,12 @@ def create_identifier(handler: Callable): | |||
| # 2) prompt-toolkit checks if we are at the end of text, not end of line | |||
| # hence it does not work in multi-line mode of navigable provider | |||
| Binding( | |||
| auto_suggest.accept_in_vi_insert_mode, | |||
| auto_suggest.accept_or_jump_to_end, | |||
There was a problem hiding this comment.
If a user configured shortcuts, their custom configuration will no longer work after this change. This is a twofold issue:
- if they overridden (modified/removed) this shortcut by matching by the old command name (
accept_in_vi_insert_mode), the override will no longer work as it will not find a match (accept_in_vi_insert_modeis no longer here) - if they added a new shortcut using the old command name, it will not work either as
accept_in_vi_insert_modecommand is not exposed anymore (currently we only allow commands which are in existing bindings; we could have a separate register of additional allowed commands which would alleviate this problem)
This is relatively minor breakage given that shortcuts were just introduced, and the name of this command was in a way misleading (it does not check for vi insert mode), so I don't have a strong opinion here.
There was a problem hiding this comment.
Good point, though if we don't emit a deprecation warning people will use the old name for ever.
Let's try to break, and if we have complaints I can do a patch release.
This is a pre-requisite of #13992 but the shortcut is disabled by default by `never` filter. The idea here is that this could be merged as-is (ideally after rebasing on top of #13991) to allow user testing. Once this is in, users can emulate part of the behaviour proposed in #13992 with the following snippet: ```python custom_shortcuts = [ { "command": "IPython:auto_suggest.resume_hinting", "new_keys": ["right"], "new_filter": "default_buffer_focused & ((vi_insert_mode & ebivim) | emacs_insert_mode)" } ] %config TerminalInteractiveShell.shortcuts = custom_shortcuts ```
Fixes #13970. Relates to #13443.
Documents #12603 with a new
emacs_like_insert_modefilter alias.