Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support go1.21.0 #141

Closed
chenrui333 opened this issue Aug 13, 2023 · 7 comments · Fixed by #144
Closed

Support go1.21.0 #141

chenrui333 opened this issue Aug 13, 2023 · 7 comments · Fixed by #144
Labels
effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up

Comments

@chenrui333
Copy link

Bug Description

Need to bump quic-go to 0.37.4 for building with go1.21.0

relates to quic-go/quic-go#4020
relates to Homebrew/homebrew-core#134468
@chenrui333 chenrui333 added the need/triage Needs initial labeling and prioritization label Aug 13, 2023
@welcome
Copy link

welcome bot commented Aug 13, 2023

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@chenrui333 chenrui333 mentioned this issue Aug 13, 2023
Merged
89 tasks
@hsanjuan
Copy link
Contributor

I don't think quic-go at that version is supported by libp2p yet (or go1.21), so this cannot be done yet.

@lidel
Copy link
Member

lidel commented Aug 14, 2023

This will be unblocked by libp2p v0.30 – see ipfs/kubo#10064 (comment)

@lidel lidel added the status/blocked Unable to be worked further until needs are met label Aug 14, 2023
@chenrui333
Copy link
Author

FYI libp2p v0.30 has landed.

@lidel lidel added P1 High: Likely tackled by core team if no one steps up effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo and removed status/blocked Unable to be worked further until needs are met need/triage Needs initial labeling and prioritization labels Sep 4, 2023
@lidel
Copy link
Member

lidel commented Sep 4, 2023

Likely to be tackled after ipfs/kubo#10064

@hacdias
Copy link
Member

hacdias commented Sep 26, 2023

This can be addressed after Kubo 0.23 is released ipfs/kubo#10014.

@bsiegert
Copy link

@hacdias Kubo 0.23 was released on October 5.

@hacdias hacdias mentioned this issue Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade to Go 1.21 ipfs/ipget
5 participants
@lidel @bsiegert @hsanjuan @chenrui333 @hacdias