Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shelljs exec usage, part 2 #32

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Conversation

airdrummingfool
Copy link
Contributor

Sorry, I missed a couple of places where .output was used.

Ref #30.

`output` was replaced with `stdout` in shelljs 0.6.0.
@shazron
Copy link
Contributor

shazron commented Feb 11, 2022

I'm going to be adding tests tomorrow, just in case, so we don't have to have part 3 :)

@shazron shazron mentioned this pull request Feb 11, 2022
@airdrummingfool
Copy link
Contributor Author

That's a good idea. I double-checked this time around, but it's always nice to have more checks 😅

@shazron
Copy link
Contributor

shazron commented Feb 11, 2022

merged in the unit tests to this, but now there is a lint error. I'll fix it later and merge this :)

@shazron shazron merged commit dfbfc5f into ios-control:master Feb 11, 2022
@airdrummingfool airdrummingfool deleted the patch-1 branch February 11, 2022 15:56
@airdrummingfool
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants