Fix shelljs exec return object usage. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In shelljs v0.6.0 (shelljs/shelljs@8a7f7ce), the `output` property was changed to `stdout`.
shazron
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30, credit to @tzmartin for the fix.
In shelljs v0.6.0 (shelljs/shelljs@8a7f7ce), the
outputproperty was changed tostdout.When simctl 2.0.1 was released, it bumped shelljs from 0.2.6 to 0.8.5, which includes the above change. This broke things (see #30).
breaking change: This PR will require consumers of the
check_prerequisitesoutput object to change their usage (to be consistent with the output of shelljs), but it seems like a small break, given that it only changes where the error message is saved (and the underlying change came in 2.0.1 with the shelljs version update).Note: Please release a new version in the 2.0.x chain once this is merged, so that all packages that depend on simctl as
"^2.0.0"can get this new version automatically.