does not works #18
Comments
|
Seeing the same myself, lots of similar errors |
|
Probably the main reason is dart-sass and node-sass differences |
|
It could be related sass/dart-sass#568 |
|
I faced and solved this issue by installing a version of ionic/core stencil one friendly (as displayed in the breaking changes list https://github.com/ionic-team/stencil/blob/master/BREAKING_CHANGES.md#stencil-one) |
|
Does anybody find the solution for this issue? "@stencil/sass": "^1.0.0", |
|
downgrade to @stencil/sass@0.1.1 |
|
Thanks @FDiskas, it has resolved that issue but got a new error now. stencil.config.ts looks like: Any idea why? |
|
I'm having the exact same issue |
|
I've been unable to get stencil/sass to work in any real capacity. The 1.0.1 version seems to just complain about any and every import I pass in ("can't find stylesheet to import, though it often shows text from that stylesheet IN the error message) If I downgrade, I get the error about not having the plugin initialized. Also, should we be able to specify a scss file (with imports) as a the |
|
Did you really installed |
|
yep. Sass is running, errors are getting kicked out by sass compiler itself. I can get it working by only including it in a component directly. As soon as I try to handle includes from my scss files... stuff starts blowing up. |
|
Is it possible that this oldish bug might be the cause of inability to import scss files from a parent scss file? Or is it truly a different sass library? |
|
I tried to build a unit test, to simulate the kinds of things I EXPECT to work, but dont seem to. While I can get this to build, jest fails to execute complaining about |
|
@stencil/sass@^1.0.0 works but has some compatibility issues. I too faced random errors in SCSS compilation with "@stencil/sass@^1.0.0", but because the error message did make little sense, pointed me to "sass-inline-svg" plugin not being compatible with this "@stencil/sass@^1.0.0", though same SCSS was working well with "@stencil/sass@^0.1.1". Following were the errors in files, where i had used SVG. `[ ERROR ] sass error: src/components/secondary-nav/secondary-nav.default.scss:4:31 ` To fix this I replaced SVG inlining process with "sass-inline-svg" to "postcss-url" package and everything started to work as before. |
|
+1 my own investigation leads to node-sass VS dart-sass encoding handling differences. |
|
Not sure this will solve the overall issue here but here is how I've handled mine. Here is the detail of the issue Contrary to my initial understanding this is not a problem with the hexcolor variable itself but with a mixin doing some string casting and manipulation. Was working perfectly in node-sass but alas not supported in dart-sass TLDR |
|
I get the same issue ...'TypeError: Cannot read property...". Simply by following the readme's I ended up with two dependencies: "@stencil/core": "^1.3.0", "@stencil/sass": "^1.0.1" My scss only contains one import and I added an includePaths to my node_modules/@thirdpartypackage in the plugins configuration for sass. (thirdpartypackage is also in a npm dependency) By reading this thread, I still have no idea what I can do to fix this... |
|
downgrade to @stencil/sass@0.1.1 |
In my experience with it, usually an issue with compatibility of additional module you might be using within SCSS. The error reported is very much random. So, if you narrow the scope of input SCSS you should be able to pinpoint the real problem and find an alternative solution. |
|
Downgrade does not work, as mentioned earlier in this thread, I get a plugin not found when using the old version of stencil/sass. I'm only importing another scss from an external dependency. Not sure how I can pinpoint the problem or fix it, as this code is not under my control. |
|
Can you share your project? |
|
Hey all, if you can confirm for me if this still exists after using @stencil/sass@1.15.0-0, an upcoming prerelease, I would really appreciate it! |
rwaskiewicz
added
Resolution: Needs Investigation
rwaskiewicz
added
the
ionitron: needs reproduction
|
Thanks for the issue! This issue has been labeled as Please reproduce this issue in an Stencil starter component library and Stencil Sass. Please provide a way for us to access it (GitHub repo, StackBlitz, etc). Without a reliable code reproduction, it is unlikely we will be able to resolve the issue, leading to it being closed. If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was not enough for our team to reproduce the issue. For a guide on how to create a good reproduction, see our Contributing Guide. |
rwaskiewicz
removed
the
Resolution: Needs Investigation
|
V2 of sass plugin works for me I can't reproduce it with latest versions installed |
|
Thanks @FDiskas! In that case, I'm going to close this issue. Thanks again! |
@ionic/core@4.2.0
@stencil/core@0.18.1-0
@stencil/sass@0.2.1
If I downgrade to
@stencil/sass@0.1.1it works againThe text was updated successfully, but these errors were encountered: