bug: reorder event gives incorrect 'to' value when an item is dragged far enough

[tobysmith568]

Prequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Ionic Framework Version

• v4.x
• v5.x
• v6.x

Current Behavior

The to field on the ItemReorderEventDetail event is off-by-one (too high) when an item is dragged past the end the list.

Expected Behavior

The to field should never be more that the number of items - 1.

Steps to Reproduce

I have created a repro but this can also be reproduced in the ionic unit tests found at src/components/reorder-group/test/basic.

• Run the app
  • If using the ionic unit tests: toggle on the reorder behaviour
• Open the browser console
• Drag an item to the end of the list, ensuring that is is dragged only just far enough to be in the last position
  • The console shows that it was dragged to index 11
• Drag an item to the end of the list, ensuring that it is dragged as far as it possibly can be
  • The console shows that it was dragged to index 12

Code Reproduction URL

https://github.com/tobysmith568/ionic-reorder-repro

Ionic Info

Ionic:

Ionic CLI : 6.16.3 (C:\Users\tobys\AppData\Roaming\nvm\v14.15.0\node_modules@ionic\cli)
Ionic Framework : @ionic/angular 5.6.14
@angular-devkit/build-angular : 12.1.4
@angular-devkit/schematics : 12.1.4
@angular/cli : 12.1.4
@ionic/angular-toolkit : 4.0.0

Utility:

cordova-res : 0.15.3
native-run : not installed globally

System:

NodeJS : v14.15.0 (C:\Tools\nodejs\node.exe)
npm : 6.14.8
OS : Windows 10

Additional Information

Will be providing a PR with a possible solution soon.
PR: #23797

[liamdebeasi]

Thanks for the issue. This has been resolved via #23797, and a fix will be available in an upcoming release of Ionic Framework. Thanks for putting up the PR!

[tobysmith568]

Hey, thanks 🎉

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.