bug: ion-nav animation always reset by router

[MarkChrisLevy]

Prequisites

• I have read the Contributing Guidelines.
• I agree to follow the Code of Conduct.
• I have searched for existing issues that already report this problem, without success.

Ionic Framework Version

• v4.x
• v5.x
• v6.x

Current Behavior

When ion-nav has animation prop set to custom transition, the transition is never used when page change is triggered by ion-router.

Expected Behavior

When ion-nav has animation prop, the custom transition should be used instead of default (mode specific) transition.

Steps to Reproduce

1. Define router with some routes
2. For ion-nav set custom transition (e.g. when in md mode set animation=iosTransitionAnimation from "@ionic/core" package)
3. Trigger page change with ion-route-link or other component that uses ion-router for page changes

Code Reproduction URL

No response

Ionic Info

5.6.13

Additional Information

No response

[MarkChrisLevy]

PR is comming...

[liamdebeasi]

Thanks! Looks like animationBuilder needs to be set after ...opts here: https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/nav/nav.tsx#L875

This is the same thing as what we did for ion-router-outlet: https://github.com/ionic-team/ionic-framework/blob/main/core/src/components/router-outlet/route-outlet.tsx#L230-L231

[MarkChrisLevy]

@liamdebeasi exactly, I will make a PR in a moment

[MarkChrisLevy]

@liamdebeasi Done

[liamdebeasi]

Thanks for the issue. This has been resolved via #23779, and a fix will be available in an upcoming release of Ionic Framework.

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.