Skip to content

fix(react): add SSR check to IonTabs #23696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2021
Merged

fix(react): add SSR check to IonTabs #23696

merged 3 commits into from
Aug 2, 2021
+7 −2

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented Jul 27, 2021 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23651

What is the new behavior?

  • IonTabs now checks for SSR when using window and HTMLElement in React

Does this introduce a breaking change?

  • Yes
  • No

Sorry, something went wrong.

@github-actions github-actions bot added the package: react @ionic/react package label Jul 27, 2021
@willmartian willmartian marked this pull request as ready for review July 30, 2021 13:49
@willmartian willmartian requested a review from liamdebeasi July 30, 2021 13:49
liamdebeasi
liamdebeasi approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👍

@willmartian willmartian merged commit f2a05be into main Aug 2, 2021
@willmartian willmartian deleted the FW-78 branch August 2, 2021 14:28
@liamdebeasi liamdebeasi mentioned this pull request Aug 2, 2021
Closed
6 tasks
This was referenced Sep 25, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi

Assignees
No one assigned
Labels
package: react @ionic/react package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: react, tabs accesses values that are not defined in ssr environment
2 participants
@willmartian @liamdebeasi