fix(ion-item-sliding): open buttons immediately on first swipe close… #23683
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
This is working great on my end, and ion-item-sliding is much more responsive now. Thank you!
I posted a dev build in #21579 and would like to see some developers try it in their app before we merge this.
willmartian
approved these changes
Jul 26, 2021
Ok, You are welcome, I will wait for the merge🙂, I hope it will not take long, thanks for your attention and a quick response 👍 |
|
Merged. Thank you! |
This was referenced Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When swipe on the first element to open the buttons, the buttons open immediately, if swipe on another element, the buttons will not open, they will open only if swipe a second time
Issue Number: resolves #21579
What is the new behavior?
Buttons open immediately after swiping on items
Does this introduce a breaking change?