Skip to content

fix(animation): typescript interface has correct return value for progress methods #23536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 29, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

TypeScript interface says progressStart, progressStep, and progressEnd methods return void, but they actually return Animation: https://github.com/ionic-team/ionic-framework/blob/master/core/src/utils/animation/animation.ts#L661-L740

ionic-team/ionic-docs#1930

What is the new behavior?

  • TypeScript interface has correct return value now

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
belimawr Tiago Queiroz
@github-actions github-actions bot added the package: core @ionic/core package label Jun 29, 2021

Verified

This commit was signed with the committer’s verified signature. The key has expired.
belimawr Tiago Queiroz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant