Skip to content

fix(vue): IonTabs can now accept IonRouterOutlet #23477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2021
Merged

fix(vue): IonTabs can now accept IonRouterOutlet #23477

merged 3 commits into from
Jun 21, 2021

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 21, 2021

v6 Docs: ionic-team/ionic-docs#1972
v5 Docs: ionic-team/ionic-docs#1973
Vue Tabs Starter: ionic-team/starters#1685

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23321

What is the new behavior?

  • IonTabs can now accept an IonRouterOutlet so developers can access the IonRouterOutlet props within a tabs context.
  • Existing developers can continue to use the default IonRouterOutlet provided in IonTabs, though this behavior will not be supported in Framework v6.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@github-actions github-actions bot added the package: vue @ionic/vue package label Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: @ionic/vue ion-tabs can't access ion-router-outlet properties
1 participant