Skip to content

fix(slides): undefined error is no longer thrown after destroying and quickly re-creating ion-slides #23239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #22289

What is the new behavior?

  • Add an undefined check in optionsChanged before updating swiper instance

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@github-actions github-actions bot added the package: core @ionic/core package label Apr 26, 2021
@liamdebeasi liamdebeasi merged commit 2ccaabb into master Apr 26, 2021
@liamdebeasi liamdebeasi deleted the swiper-undefined branch April 26, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Swiper params is null/undefined after slides are cleared
1 participant