Skip to content

fix(angular): back button goes back to proper tab on angular 11.2.10 #23238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 26, 2021

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23230

What is the new behavior?

  • Created a deep copy of the route when deactivating to account for angular clearing out that context in v11.2.10

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@github-actions github-actions bot added the package: angular @ionic/angular package label Apr 26, 2021
@liamdebeasi
Copy link
Contributor Author

Note: Not adding a test because we already have one for this use case: 52e5a8d

Just bumped the test app to ng11 so that this angular change is present.

@liamdebeasi liamdebeasi changed the title fix(angular): going back to tab context now returns you to correct tab on angular 11.2.10 fix(angular): back button goes back to proper tab on angular 11.2.10 Apr 26, 2021
@liamdebeasi liamdebeasi merged commit e436439 into master Apr 26, 2021
@liamdebeasi liamdebeasi deleted the ng-router-url branch April 26, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Angular Router fix in 11.2.10 breaks expected behavior for ion-router-outlet?
1 participant