Skip to content

fix(segment, segment-button): use correct tablist and tab roles for screen readers #23145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 12, 2021

Conversation

willmartian
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23059

What is the new behavior?

  • ion-segment now uses role="tablist"
  • ion-segment-button now uses role="tab" and updates aria-selected based on its selected state
  • ion-segment-button now passes the aria-controls attribute to its child button element

Does this introduce a breaking change?

  • Yes
  • No

@willmartian willmartian requested a review from liamdebeasi April 5, 2021 15:07
@github-actions github-actions bot added the package: core @ionic/core package label Apr 5, 2021
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@liamdebeasi liamdebeasi changed the title fix(segment, segment-button): change aria attributes for segment and segment-button fix(segment, segment-button): use correct tablist and tab roles for screen readers Apr 9, 2021
@willmartian willmartian merged commit 91ac340 into master Apr 12, 2021
@liamdebeasi liamdebeasi deleted the fix/23059 branch April 22, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-segment a11y - role should be tablist, buttons should use aria-selected
2 participants