Skip to content

bug(router): route-redirect does not honor the query string #23136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vicb opened this issue Apr 3, 2021 · 2 comments · Fixed by #23337
Closed

bug(router): route-redirect does not honor the query string #23136

vicb opened this issue Apr 3, 2021 · 2 comments · Fixed by #23337
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@vicb
Copy link
Contributor

vicb commented Apr 3, 2021

Bug Report

Ionic version:

[ ] 4.x
[x] 5.6

Current behavior:

<ion-route-redirect from="/redirect" to="/foo?src=redirect"></ion-route-redirect>

would redirect to /foo

Expected behavior:

<ion-route-redirect from="/redirect" to="/foo?src=redirect"></ion-route-redirect>

should redirect to /foo?src=redirect

Steps to reproduce:
Related code:

https://runkit.com/vicb/ionic-router-redirect---query-string

using this runkit:

  • click on "go to foo", the url changes to /foo?src=button,
  • click on "redirect to foo", the url changes to /foo but we want /foo?src=redirect

Other information:

This feature is missing from the ionic source code.
It would be easy to implement and I am happy to contribute a fix.
I would make sense to merge #23123 first though.

@ionitron-bot ionitron-bot bot added the triage label Apr 3, 2021
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Apr 5, 2021
@ionitron-bot ionitron-bot bot removed triage labels Apr 5, 2021
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #23337, and a fix will be available in an upcoming release of Ionic Framework.

liamdebeasi pushed a commit that referenced this issue May 21, 2021

Verified

This commit was signed with the committer’s verified signature.
Lord-Kamina Gregorio Litenstein
resolves #23136
@ionitron-bot
Copy link

ionitron-bot bot commented Jun 20, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants