fix(virtual-scroll): allow null in items prop #23047
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Using the async pipe is considered best practice for angular projects.
When using the
async
pipe with<ion-virtual-scroll>
withstrictTemplates
set totrue
intsconfig.json
we get this errorType 'null' is not assignable to type 'any[] | undefined'.
during the build phase.Issue Number: N/A
What is the new behavior?
When setting
angularCompilerOptions.strictTemplates=true
intsconfig.json
the build fails because there is a type mismatch between async & [items]. This is because the return type of async can beany[] | null
whereas [items] only acceptsany[] | undefined
. Adding null to the allowed types fixes the issue and allows async to be used with virtual scroll.Does this introduce a breaking change?
Other information