Skip to content

fix(): overlays now present correctly when using custom elements build #23039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 15, 2021
Merged

fix(): overlays now present correctly when using custom elements build #23039

merged 7 commits into from
Mar 15, 2021
+56 −2

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23029

What is the new behavior?

  • Element ref is passed in callback
  • We now wait in an raf before calling callback with CE build

Does this introduce a breaking change?

  • Yes
  • No

Other information

Sorry, something went wrong.

@github-actions github-actions bot added the package: core @ionic/core package label Mar 12, 2021
vicb
vicb reviewed Mar 12, 2021
View reviewed changes
vicb
vicb reviewed Mar 13, 2021
View reviewed changes
core/src/utils/test/ready.spec.ts
}
});

const component = document.createElement('hello-world');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use "eager-component" / "lazy-component" instead of "hello-world" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lazy vs non lazy difference is already noted in the name of the test, so not sure this change would make much of a difference.

@vicb
Copy link
Contributor

vicb commented Mar 13, 2021

Thanks a lot for working on this @liamdebeasi
The PR looks great 👍

@liamdebeasi liamdebeasi merged commit e4bf052 into master Mar 15, 2021
@liamdebeasi liamdebeasi deleted the ce-wait branch March 15, 2021 13:13
@liamdebeasi liamdebeasi mentioned this pull request Mar 15, 2021
Closed
This was referenced Mar 18, 2021
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(overlay): alert/modal not showing with element build (5.6.0)
2 participants
@liamdebeasi @vicb