fix(react, vue): tab buttons no longer throw an error if href is undefined #22998
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #22997
It's currently impossible to do custom click handlers right now because the
href
always takes priority. Leaving thehref
off will cause the click handler to fire, but it causes errors. The underlying WC for tab button allows an undefined href without crashing, so we need to here as well.What is the new behavior?
path
is defined before attempting to switch tabs.path
prop is optional on the regular web component ion-tab-button, so we should expect it to be undefined here as well. Also allows devs to override the default tab button behavior and add their own click handler.tab
because even though it defaults toundefined
it is a required prop according to the docs.Does this introduce a breaking change?
Other information