fix(label): do not show placeholder with floating label until focus #22958
+199
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with-placeholde# Please enter a commit message to explain why this merge is necessary,
github-actions
bot
added
package: angular
liamdebeasi
force-pushed
the
fix-floating-label-with-placeholder
branch
from
5edad05 to
7f7fb96
Compare
github-actions
bot
removed
package: react
liamdebeasi
approved these changes
Mar 1, 2021
cerkiner
added a commit
to cerkiner/ionic
that referenced
this pull request
Mar 2, 2021
* master: (284 commits) fix(label): only show placeholder with floating label when focused (ionic-team#22958) feat(react): add react hooks to control overlay components (ionic-team#22484) feat(vue): add composition API ionic lifecycle hooks (ionic-team#22970) chore(): run build 5.5.5 fix(vue): account for event name changes in vue 3.0.6+ fix(react, vue): navigating using ion-back-button now selects correct page (ionic-team#22974) fix(progress-bar): use correct theme colors in dark mode (ionic-team#22965) fix(progress-bar): add width transition (ionic-team#22964) fix(vue): prevent race conditions when opening overlays (ionic-team#22883) fix(progress-bar): use correct theme colors in dark mode (ionic-team#22957) feat(searchbar): add showClearIcon property (ionic-team#22759) test(): update theming test with latest dark mode values (ionic-team#22956) chore(): update package-lock to account for npm 7.5.3 bug fix (ionic-team#22963) fix(header): collapsed toolbar is no longer incorrectly shown when using ion-refresher (ionic-team#22937) fix(react): onIonTabsWillChange and onIonTabsDidChange event handlers are now properly bound to IonTabs (ionic-team#22233) fix(refresher): add correct dark mode styles (ionic-team#22639) feat(custom-elements): add experimental custom elements build (ionic-team#22863) fix(a11y): improve support for ids with special characters when getting label element (ionic-team#22680) chore(): update code of conduct (ionic-team#22619) ...
|
This is still an issue with IonSelect and IonDateTime - I can see it's fixed for IonInput but still an issue for these 2 components. Previous versions, the placeholder text would have been visible even on an unfocused input with the floating label already in the "highest" position as if there was a value. With the latest change, there is no placeholder until you click the input (it becomes focused). Is this the intended functionality? To change how it was previously? I've only noticed this after upgrading Ionic core and Ionic React in one of our apps from 5.3.1 to 5.6 and I've had to downgrade now. Screen.Recording.2021-03-11.at.16.15.07.movEDIT: |
|
Here's how it looked previously |
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: fixes #17571
What is the new behavior?
Does this introduce a breaking change?
Other information
This is a design improvement that gets us closer to the MD spec here:
It is currently applied to iOS too, may need a design decision on this.