Skip to content

bug: ionic react, IonRouterOutlet animated=false not working #22903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Aupourbau opened this issue Feb 10, 2021 · 4 comments · Fixed by #22905
Closed

bug: ionic react, IonRouterOutlet animated=false not working #22903

Aupourbau opened this issue Feb 10, 2021 · 4 comments · Fixed by #22905
Labels
package: react @ionic/react package type: bug a confirmed bug report

Comments

@Aupourbau
Copy link

Bug Report

Ionic version:
[ ] 4.x
[x] 5.5.0 (ionic-react)

Current behavior:
Animation between pages is not disabled when "animated" is set to false for IonRouterOutlet

Expected behavior:
Expecting no animation between pages when "animated" is set to false

Steps to reproduce:
ionic start myApp conference
Framework: React
npm i @ionic/react@latest @ionic/react-router@latest
add animated={false} to IonRouterOutlet in App.tsx
Alternate click on 'Skip' in tutorial page and 'show Tutorial' in tabs/schedule

Ionic info:
Ionic:

Ionic CLI : 6.12.4 (/usr/local/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/react 5.5.4

Capacitor:

Capacitor CLI : 1.3.0
@capacitor/core : 1.3.0

Utility:

cordova-res (update available: 0.15.3) : 0.15.2
native-run : not installed

System:

NodeJS : v12.18.3 (/usr/local/bin/node)
npm : 7.5.2
OS : macOS Mojave

@ionitron-bot ionitron-bot bot added the triage label Feb 10, 2021
@liamdebeasi liamdebeasi added package: react @ionic/react package type: bug a confirmed bug report labels Feb 10, 2021
@liamdebeasi liamdebeasi changed the title bug: IonRouterOutlet animated=false not working bug: ionic react, IonRouterOutlet animated=false not working Feb 10, 2021
@ionitron-bot ionitron-bot bot removed the triage label Feb 10, 2021
@liamdebeasi
Copy link
Contributor

Thanks for the issue. Can you try the following dev build and let me know if it resolves the issue?

npm install @ionic/react@5.6.0-dev.202102101503.5fd1f35 @ionic/react-router@5.6.0-dev.202102101503.5fd1f35

@Aupourbau
Copy link
Author

Thanks for the issue. Can you try the following dev build and let me know if it resolves the issue?

npm install @ionic/react@5.6.0-dev.202102101503.5fd1f35 @ionic/react-router@5.6.0-dev.202102101503.5fd1f35

Working fine, thanks!

@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #22905, and a fix will be available in an upcoming release of Ionic Framework.

liamdebeasi added a commit that referenced this issue Feb 10, 2021

Verified

This commit was signed with the committer’s verified signature.
flavorjones Mike Dalessio
resolves #22903
@ionitron-bot
Copy link

ionitron-bot bot commented Mar 12, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: react @ionic/react package type: bug a confirmed bug report
Projects
None yet
2 participants