-
Notifications
You must be signed in to change notification settings - Fork 13.5k
feat: users should be able to customize accessibility defaults #21327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@liamdebeasi Hello, I am a deaf, blind and wheelchair. I'm having a hard time trying to issues The code goes something like this: õion-header mode = "ios" translucent = "true" role = "none"> Appears without Braille display: banner, hello everyone!, banner landmark It looks awful. Fix this is very important, as it takes the efficiency of the APP for the disabled. Please answer me. Thank you! |
21327 Hello, Please understand. I'm an Ionic programmer. I can't delete My Braille display only has 32 characters per content. <ion-header translucent ="true" mode ="ios" role ="none"o But don't delete the The code above is identifier like this on the Braille display in the APP on the iPhone: banner, Hello everyone, banner landmark This is horrible using a Braille display. Fix this issue is very important. Please help me. Thank! |
Hi, I'm @paulobr01 's friend and I help him with some things. If I could help with something about his issue with the Ionic banner bug he's reporting, you can talk to me too. Thank you! |
Hi @paulobr01 and @masbrutus, Thanks for the feedback! Let me look into this issue and see if we can make |
Hey there, I have merged in #23888 which lets developers customize the On a separate note regarding the GitHub issue itself, I am going to close this out in favor of having one GitHub thread per issue as opposed to having all issues tracked in this thread. This makes it much easier for us to track progress and provide updates to the community. For any additional issues, please feel free to open separate GitHub issues. Thank you! |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Bug Report
Ionic version:
[x] 5.x
Current behavior:
Often times users will want to customize the accessibility defaults we provide for components. For example, if a user is distributing an app in multiple languages, having a label always be announced in English is not very helpful. Additionally, even if users are distributing an app in English only, they cannot override the defaults we provide.
For example, we add
role="banner"
to the Host ofion-header
(https://github.com/ionic-team/ionic/blob/master/core/src/components/header/header.tsx#L148). This may not be desirable to some users and they may wish to userole="none"
; however, they are unable to override this asrole="banner"
is always used. On top of this, if we provide any attributes to elements inside the shadow dom, users cannot easily access them to customize them. Users can access them via JS andshadowRoot
, but that is not a sustainable approach.Expected behavior:
I would expect that developers can customize most/all of the accessibility defaults we provide to fine tune the user experience for their applications.
This thread will be used to track areas where there needs to be improvement regarding this.
The text was updated successfully, but these errors were encountered: