Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Progress bar radius property #20062

Closed
Fdom92 opened this issue Dec 11, 2019 · 3 comments · Fixed by #22938
Closed

feat: Add Progress bar radius property #20062

Fdom92 opened this issue Dec 11, 2019 · 3 comments · Fixed by #22938
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Milestone

Comments

@Fdom92
Copy link

Fdom92 commented Dec 11, 2019

Feature Request

Ionic version:
[x] 4.x

Describe the Feature Request
The ion progress bar component is not easy to customize the border radius of the inner progress bar. We can easily modify the outer progress bar radius, but not the inner one.

Describe Preferred Solution
Be able to adjust the inner radius with CSS Properties

Describe Alternatives
Would be awesome to have a CSS Property like --inner-progress-radius to be able to adjust the radius easily

@ionitron-bot ionitron-bot bot added the triage label Dec 11, 2019
@liamdebeasi liamdebeasi added package: core @ionic/core package type: feature request a new feature, enhancement, or improvement labels Dec 11, 2019
@ionitron-bot ionitron-bot bot removed the triage label Dec 11, 2019
@pritamsoni-hsr
Copy link

@Fdom92 you can modify the source code after build and change transform:scaleX(e) to width:calc(e*100%), then you can add radius to .progress class

@liamdebeasi using above method when progress bar's width doesn't change very frequently, having an extra prop dynamic = true or false can specify whether to use scaleX or width

itsonit added a commit to itsonit/ionic-framework that referenced this issue Oct 7, 2020
@kensodemann
Copy link
Member

I am working with someone who is also having this issue. Interestingly, this sample works fine on Chrome with standard light-dom styling but fails on Safari (and also on iOS then of course).

@brandyscarney brandyscarney added this to the 5.6.0 milestone Feb 16, 2021
brandyscarney added a commit that referenced this issue Mar 4, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
resolves #20062 fixes #21820
@ionitron-bot
Copy link

ionitron-bot bot commented Apr 3, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
5 participants