Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): show correct activated state for ios #26900

Merged
merged 19 commits into from
Mar 7, 2023
Merged

fix(button): show correct activated state for ios #26900

merged 19 commits into from
Mar 7, 2023

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Mar 2, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • The activated state does not show up on iOS while hovering
  • Outline buttons in a toolbar aren't showing activated state at all

Issue URL: fixes #22468

What is the new behavior?

  • Display activated states for buttons when pressing while hovering
  • Show the activated state for outline buttons in a toolbar (updated to match what an outline button with color was already doing)
  • While fixing the above there were some issues that popped up, resolved all found issues

Does this introduce a breaking change?

  • Yes
  • No

Other information

The following tests should show no differences:

  • button/basic
  • button/clear
  • button/outline

The following tests will show fixes where activated was not being applied at all for outline buttons, regardless of hover state. I made edits to these tests on my branch in order to check more use cases, so these diffs won't show up in screenshot comparisons:

test main branch
toolbar/basic toolbar - basic 1 toolbar - basic 2
toolbar/colors toolbar - colors 2 toolbar - colors 1
themes/default themes - default themes - default
themes/oceanic themes - oceanic themes - oceanic
themes/vibrant themes - vibrant themes - vibrant
themes/dark themes - dark themes - dark

Sorry, something went wrong.

@stackblitz
Copy link

stackblitz bot commented Mar 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Mar 2, 2023
brandyscarney and others added 3 commits March 2, 2023 16:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@brandyscarney brandyscarney marked this pull request as ready for review March 2, 2023 23:09
@brandyscarney brandyscarney requested a review from a team as a code owner March 2, 2023 23:09
brandyscarney and others added 7 commits March 3, 2023 09:52

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
brandyscarney and others added 5 commits March 6, 2023 12:19

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@brandyscarney brandyscarney merged commit 67815cc into main Mar 7, 2023
@brandyscarney brandyscarney deleted the FW-3481 branch March 7, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: hover state covers activated state on button
3 participants